src/api-arguments.h - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-arguments.h

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebase master Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api-arguments.h

diff --git a/src/api-arguments.h b/src/api-arguments.h

index 57a2d98db11b2bf558691a00cde8ead960943c97..f1573fe83fa469f276ad8832a9ee4b28bf0291fc 100644

--- a/src/api-arguments.h

+++ b/src/api-arguments.h

@@ -58,7 +58,7 @@ Handle<V> CustomArguments<T>::GetReturnValue(Isolate* isolate) {

// Check the ReturnValue.

Object** handle = &this->begin()[kReturnValueOffset];

// Nothing was set, return empty handle as per previous behaviour.

- if ((*handle)->IsTheHole()) return Handle<V>();

+ if ((*handle)->IsTheHole(isolate)) return Handle<V>();

Handle<V> result = Handle<V>::cast(Handle<Object>(handle));

result->VerifyApiCallResultType();

return result;

« no previous file with comments | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »