src/runtime/runtime-literals.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-literals.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixing wrongly wrapped lines Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-literals.cc

diff --git a/src/runtime/runtime-literals.cc b/src/runtime/runtime-literals.cc

index 5cb97c6ce673009b02e1763a1f422a3775dbacc8..4159f765bea41dc028773f2402e4b372629553d9 100644

--- a/src/runtime/runtime-literals.cc

+++ b/src/runtime/runtime-literals.cc

@@ -209,7 +209,7 @@ RUNTIME_FUNCTION(Runtime_CreateRegExpLiteral) {

// Check if boilerplate exists. If not, create it first.

Handle<Object> boilerplate(closure->literals()->literal(index), isolate);

- if (boilerplate->IsUndefined()) {

+ if (boilerplate->IsUndefined(isolate)) {

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

isolate, boilerplate, JSRegExp::New(pattern, JSRegExp::Flags(flags)));

closure->literals()->set_literal(index, *boilerplate);