src/log.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixing wrongly wrapped lines Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 201a9ef9be65fa269e1a65a96e1a153d9b39eda1..835e48bd976d6c05a16e3b703fcececff8eb132f 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -1684,7 +1684,7 @@ void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,

// API function.

FunctionTemplateInfo* fun_data = shared->get_api_func_data();

Object* raw_call_data = fun_data->call_code();

- if (!raw_call_data->IsUndefined()) {

+ if (!raw_call_data->IsUndefined(isolate_)) {

CallHandlerInfo* call_data = CallHandlerInfo::cast(raw_call_data);

Object* callback_obj = call_data->callback();

Address entry_point = v8::ToCData<Address>(callback_obj);