src/json-parser.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-parser.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixing wrongly wrapped lines Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-parser.cc

diff --git a/src/json-parser.cc b/src/json-parser.cc

index e1a342150cbad0e5a7103d896478d3b2f47cc683..584c05e0b1f2e9206e612f331157d1f0a8c99f13 100644

--- a/src/json-parser.cc

+++ b/src/json-parser.cc

@@ -83,7 +83,7 @@ bool JsonParseInternalizer::RecurseAndApply(Handle<JSReceiver> holder,

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate_, result, InternalizeJsonProperty(holder, name), false);

Maybe<bool> change_result = Nothing<bool>();

- if (result->IsUndefined()) {

+ if (result->IsUndefined(isolate_)) {

change_result = JSReceiver::DeletePropertyOrElement(holder, name, SLOPPY);

} else {

PropertyDescriptor desc;