Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/frames.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: doing proper rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/factory.cc ('K') | « src/factory.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index 1fd44928b751bdc0a2452bf450b6539762bdff7a..832a88a38813b04cc126e01c6547948a73858db7 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -1348,7 +1348,8 @@ uint32_t WasmFrame::function_index() {
FixedArray* deopt_data = LookupCode()->deoptimization_data();
DCHECK(deopt_data->length() == 2);
Object* func_index_obj = deopt_data->get(1);
- if (func_index_obj->IsUndefined()) return static_cast<uint32_t>(-1);
+ Isolate* isolate = deopt_data->GetIsolate();
Michael Starzinger 2016/06/06 08:55:08 nit: isolate()
Camillo Bruni 2016/06/06 12:27:49 done
+ if (func_index_obj->IsUndefined(isolate)) return static_cast<uint32_t>(-1);
if (func_index_obj->IsSmi()) return Smi::cast(func_index_obj)->value();
DCHECK(func_index_obj->IsHeapNumber());
uint32_t val = static_cast<uint32_t>(-1);
« src/factory.cc ('K') | « src/factory.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698