Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/compiler/pipeline.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: doing proper rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/contexts.cc » ('j') | src/factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 3ce3c851586d33cc56bb06d3ec0c297c684f5ca2..4d43a249e79f92b37af361ffba2facd5698791fb 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -534,7 +534,9 @@ PipelineStatistics* CreatePipelineStatistics(CompilationInfo* info,
int pos = info->shared_info()->start_position();
json_of << "{\"function\":\"" << function_name.get()
<< "\", \"sourcePosition\":" << pos << ", \"source\":\"";
- if (!script->IsUndefined() && !script->source()->IsUndefined()) {
+ Isolate* isolate = script->GetIsolate();
Michael Starzinger 2016/06/06 08:55:08 nit: info->isolate()
Camillo Bruni 2016/06/06 12:27:49 changed.
+ if (!script->IsUndefined(isolate) &&
+ !script->source()->IsUndefined(isolate)) {
DisallowHeapAllocation no_allocation;
int start = info->shared_info()->start_position();
int len = info->shared_info()->end_position() - start;
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/contexts.cc » ('j') | src/factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698