test/cctest/heap/test-heap.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/heap/test-heap.cc

diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc

index 371c4d2097378c4cb63a09cbb42cf985611cf40e..14d0c7952d5dd68ec43fc55d6a2ccc8f7828a56e 100644

--- a/test/cctest/heap/test-heap.cc

+++ b/test/cctest/heap/test-heap.cc

@@ -6112,7 +6112,7 @@ static void CheckLeak(const v8::FunctionCallbackInfo<v8::Value>& args) {

Isolate* isolate = CcTest::i_isolate();

Object* message =

*reinterpret_cast<Object**>(isolate->pending_message_obj_address());

- CHECK(message->IsTheHole());

+ CHECK(message->IsTheHole(isolate));

}