src/wasm/wasm-js.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-js.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-js.cc

diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc

index eaae9ac5f7b93aac7e60523cb2a635f174226f8f..2c83f823556c852a38660ca87b18341ab87fb5db 100644

--- a/src/wasm/wasm-js.cc

+++ b/src/wasm/wasm-js.cc

@@ -244,7 +244,7 @@ void InstantiateModuleFromAsm(const v8::FunctionCallbackInfo<v8::Value>& args) {

DCHECK(!maybe_init.is_null());

i::Handle<i::Object> init = maybe_init.ToHandleChecked();

- i::Handle<i::Object> undefined(isolate->heap()->undefined_value(), isolate);

+ i::Handle<i::Object> undefined = isolate->factory()->undefined_value();

i::Handle<i::Object>* foreign_args_array =

new i::Handle<i::Object>[foreign_args->length()];

for (int j = 0; j < foreign_args->length(); j++) {