src/runtime/runtime-liveedit.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-liveedit.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-liveedit.cc

diff --git a/src/runtime/runtime-liveedit.cc b/src/runtime/runtime-liveedit.cc

index 6c439c1756661bf66617bbea98652541b774b1a9..72e8648a423224b9d66748e80afdda226069954b 100644

--- a/src/runtime/runtime-liveedit.cc

+++ b/src/runtime/runtime-liveedit.cc

@@ -221,7 +221,7 @@ RUNTIME_FUNCTION(Runtime_LiveEditCheckAndDropActivations) {

isolate, new_element,

JSReceiver::GetElement(isolate, new_shared_array, i));

RUNTIME_ASSERT(

- new_element->IsUndefined() ||

+ new_element->IsUndefined(isolate) ||

(new_element->IsJSValue() &&

Handle<JSValue>::cast(new_element)->value()->IsSharedFunctionInfo()));

}