src/log-utils.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log-utils.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log-utils.cc

diff --git a/src/log-utils.cc b/src/log-utils.cc

index 4c67afba31ef2f06ca0977caf3af75c4316b0552..22972ec0551bd700936332583423ef64779a152f 100644

--- a/src/log-utils.cc

+++ b/src/log-utils.cc

@@ -171,7 +171,7 @@ void Log::MessageBuilder::AppendAddress(Address addr) {

void Log::MessageBuilder::AppendSymbolName(Symbol* symbol) {

DCHECK(symbol);

Append("symbol(");

- if (!symbol->name()->IsUndefined()) {

+ if (!symbol->name()->IsUndefined(symbol->GetIsolate())) {

Append("\"");

AppendDetailed(String::cast(symbol->name()), false);

Append("\" ");

« no previous file with comments | « src/log.cc ('k') | src/lookup.cc » ('j') | src/objects.h » ('J')