Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 656bd8b78652f4f721617004bbcd9673afb9e176..afa5f1efc72dadde4cb7c6f71cdaf7ac3eb9cf74 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -1558,7 +1558,7 @@ void BytecodeGenerator::VisitLiteral(Literal* expr) {
Handle<Object> value = expr->value();
if (value->IsSmi()) {
builder()->LoadLiteral(Smi::cast(*value));
- } else if (value->IsUndefined()) {
+ } else if (value->IsUndefined(isolate())) {
builder()->LoadUndefined();
} else if (value->IsTrue()) {
builder()->LoadTrue();
@@ -1566,7 +1566,7 @@ void BytecodeGenerator::VisitLiteral(Literal* expr) {
builder()->LoadFalse();
} else if (value->IsNull()) {
builder()->LoadNull();
- } else if (value->IsTheHole()) {
+ } else if (value->IsTheHole(isolate())) {
builder()->LoadTheHole();
} else {
builder()->LoadLiteral(value);
« no previous file with comments | « src/ic/x87/handler-compiler-x87.cc ('k') | src/isolate.cc » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698