src/heap/mark-compact.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/mark-compact.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/mark-compact.cc

diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc

index 9f68ad8bbd10d25687387a2c3dc5e01fb5c27312..bf8cdbe3ae516c57b217710e8cc3ede16508959d 100644

--- a/src/heap/mark-compact.cc

+++ b/src/heap/mark-compact.cc

@@ -1074,7 +1074,7 @@ void CodeFlusher::EvictCandidate(SharedFunctionInfo* shared_info) {

void CodeFlusher::EvictCandidate(JSFunction* function) {

- DCHECK(!function->next_function_link()->IsUndefined());

+ DCHECK(!function->next_function_link()->IsUndefined(isolate_));

Object* undefined = isolate_->heap()->undefined_value();

// Make sure previous flushing decisions are revisited.