src/frames.cc - Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reducing old cmpare patterns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index 1fd44928b751bdc0a2452bf450b6539762bdff7a..832a88a38813b04cc126e01c6547948a73858db7 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1348,7 +1348,8 @@ uint32_t WasmFrame::function_index() {

FixedArray* deopt_data = LookupCode()->deoptimization_data();

DCHECK(deopt_data->length() == 2);

Object* func_index_obj = deopt_data->get(1);

- if (func_index_obj->IsUndefined()) return static_cast<uint32_t>(-1);

+ Isolate* isolate = deopt_data->GetIsolate();

+ if (func_index_obj->IsUndefined(isolate)) return static_cast<uint32_t>(-1);

if (func_index_obj->IsSmi()) return Smi::cast(func_index_obj)->value();

DCHECK(func_index_obj->IsHeapNumber());

uint32_t val = static_cast<uint32_t>(-1);