Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/runtime/runtime-liveedit.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase master Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/liveedit.h" 10 #include "src/debug/liveedit.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 214 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
215 isolate, old_element, 215 isolate, old_element,
216 JSReceiver::GetElement(isolate, old_shared_array, i)); 216 JSReceiver::GetElement(isolate, old_shared_array, i));
217 RUNTIME_ASSERT( 217 RUNTIME_ASSERT(
218 old_element->IsJSValue() && 218 old_element->IsJSValue() &&
219 Handle<JSValue>::cast(old_element)->value()->IsSharedFunctionInfo()); 219 Handle<JSValue>::cast(old_element)->value()->IsSharedFunctionInfo());
220 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 220 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
221 isolate, new_element, 221 isolate, new_element,
222 JSReceiver::GetElement(isolate, new_shared_array, i)); 222 JSReceiver::GetElement(isolate, new_shared_array, i));
223 RUNTIME_ASSERT( 223 RUNTIME_ASSERT(
224 new_element->IsUndefined() || 224 new_element->IsUndefined(isolate) ||
225 (new_element->IsJSValue() && 225 (new_element->IsJSValue() &&
226 Handle<JSValue>::cast(new_element)->value()->IsSharedFunctionInfo())); 226 Handle<JSValue>::cast(new_element)->value()->IsSharedFunctionInfo()));
227 } 227 }
228 228
229 return *LiveEdit::CheckAndDropActivations(old_shared_array, new_shared_array, 229 return *LiveEdit::CheckAndDropActivations(old_shared_array, new_shared_array,
230 do_drop); 230 do_drop);
231 } 231 }
232 232
233 233
234 // Compares 2 strings line-by-line, then token-wise and returns diff in form 234 // Compares 2 strings line-by-line, then token-wise and returns diff in form
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 // We don't really care what the inlined frame index is, since we are 278 // We don't really care what the inlined frame index is, since we are
279 // throwing away the entire frame anyways. 279 // throwing away the entire frame anyways.
280 const char* error_message = LiveEdit::RestartFrame(it.frame()); 280 const char* error_message = LiveEdit::RestartFrame(it.frame());
281 if (error_message) { 281 if (error_message) {
282 return *(isolate->factory()->InternalizeUtf8String(error_message)); 282 return *(isolate->factory()->InternalizeUtf8String(error_message));
283 } 283 }
284 return heap->true_value(); 284 return heap->true_value();
285 } 285 }
286 } // namespace internal 286 } // namespace internal
287 } // namespace v8 287 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698