Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

src/json-parser.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/json-parser.h"
 
 #include "src/char-predicates-inl.h"
 #include "src/conversions.h"
 #include "src/debug/debug.h"
 #include "src/factory.h"
@@ skipping 65 matching lines @@
       Object);
   return outer_scope.CloseAndEscape(result);
 }
 
 bool JsonParseInternalizer::RecurseAndApply(Handle<JSReceiver> holder,
                                             Handle<String> name) {
   Handle<Object> result;
   ASSIGN_RETURN_ON_EXCEPTION_VALUE(
       isolate_, result, InternalizeJsonProperty(holder, name), false);
   Maybe<bool> change_result = Nothing<bool>();
-  if (result->IsUndefined()) {
+  if (result->IsUndefined(isolate_)) {
     change_result = JSReceiver::DeletePropertyOrElement(holder, name, SLOPPY);
   } else {
     PropertyDescriptor desc;
     desc.set_value(result);
     desc.set_configurable(true);
     desc.set_enumerable(true);
     desc.set_writable(true);
     change_result = JSReceiver::DefineOwnProperty(isolate_, holder, name, &desc,
                                                   Object::DONT_THROW);
   }
@@ skipping 647 matching lines @@
                         : static_cast<uint32_t>(length);
     Vector<const uint8_t> string_vector(seq_source_->GetChars() + position_,
                                         length);
     StringTable* string_table = isolate()->heap()->string_table();
     uint32_t capacity = string_table->Capacity();
     uint32_t entry = StringTable::FirstProbe(hash, capacity);
     uint32_t count = 1;
     Handle<String> result;
     while (true) {
       Object* element = string_table->KeyAt(entry);
-      if (element == isolate()->heap()->undefined_value()) {
+      if (element->IsUndefined(isolate())) {
         // Lookup failure.
         result =
             factory()->InternalizeOneByteString(seq_source_, position_, length);
         break;
       }
-      if (element != isolate()->heap()->the_hole_value() &&
+      if (!element->IsTheHole(isolate()) &&
           String::cast(element)->IsOneByteEqualTo(string_vector)) {
         result = Handle<String>(String::cast(element), isolate());
 #ifdef DEBUG
         uint32_t hash_field =
             (hash << String::kHashShift) | String::kIsNotArrayIndexMask;
         DCHECK_EQ(static_cast<int>(result->Hash()),
                   static_cast<int>(hash_field >> String::kHashShift));
 #endif
         break;
       }
@@ skipping 33 matching lines @@
   AdvanceSkipWhitespace();
   return result;
 }
 
 // Explicit instantiation.
 template class JsonParser<true>;
 template class JsonParser<false>;
 
 }  // namespace internal
 }  // namespace v8