Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: src/debug/liveedit.cc

Issue 2028983002: Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixing wrongly wrapped lines Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/liveedit.h" 5 #include "src/debug/liveedit.h"
6 6
7 #include "src/ast/scopeinfo.h" 7 #include "src/ast/scopeinfo.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
1602 JSReceiver::GetElement(isolate, old_shared_array_, i) 1602 JSReceiver::GetElement(isolate, old_shared_array_, i)
1603 .ToHandleChecked(); 1603 .ToHandleChecked();
1604 if (!old_shared.is_identical_to(UnwrapSharedFunctionInfoFromJSValue( 1604 if (!old_shared.is_identical_to(UnwrapSharedFunctionInfoFromJSValue(
1605 Handle<JSValue>::cast(old_element)))) { 1605 Handle<JSValue>::cast(old_element)))) {
1606 continue; 1606 continue;
1607 } 1607 }
1608 1608
1609 Handle<Object> new_element = 1609 Handle<Object> new_element =
1610 JSReceiver::GetElement(isolate, new_shared_array_, i) 1610 JSReceiver::GetElement(isolate, new_shared_array_, i)
1611 .ToHandleChecked(); 1611 .ToHandleChecked();
1612 if (new_element->IsUndefined()) return false; 1612 if (new_element->IsUndefined(isolate)) return false;
1613 Handle<SharedFunctionInfo> new_shared = 1613 Handle<SharedFunctionInfo> new_shared =
1614 UnwrapSharedFunctionInfoFromJSValue( 1614 UnwrapSharedFunctionInfoFromJSValue(
1615 Handle<JSValue>::cast(new_element)); 1615 Handle<JSValue>::cast(new_element));
1616 if (new_shared->scope_info()->HasNewTarget()) { 1616 if (new_shared->scope_info()->HasNewTarget()) {
1617 SetElementSloppy( 1617 SetElementSloppy(
1618 result_, i, 1618 result_, i,
1619 Handle<Smi>( 1619 Handle<Smi>(
1620 Smi::FromInt( 1620 Smi::FromInt(
1621 LiveEdit::FUNCTION_BLOCKED_NO_NEW_TARGET_ON_RESTART), 1621 LiveEdit::FUNCTION_BLOCKED_NO_NEW_TARGET_ON_RESTART),
1622 isolate)); 1622 isolate));
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
2043 scope_info_length++; 2043 scope_info_length++;
2044 2044
2045 current_scope = current_scope->outer_scope(); 2045 current_scope = current_scope->outer_scope();
2046 } 2046 }
2047 2047
2048 return scope_info_list; 2048 return scope_info_list;
2049 } 2049 }
2050 2050
2051 } // namespace internal 2051 } // namespace internal
2052 } // namespace v8 2052 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698