Introduce IsUndefined(Isolate*) and IsTheHole(Isolate*)

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 
 #include "src/assert-scope.h"
@@ skipping 1046 matching lines @@
     if ((call).IsNothing()) return value; \
   } while (false)
 
 #define MAYBE_RETURN_NULL(call) MAYBE_RETURN(call, MaybeHandle<Object>())
 
 #define DECLARE_STRUCT_PREDICATE(NAME, Name, name) \
   INLINE(bool Is##Name() const);
   STRUCT_LIST(DECLARE_STRUCT_PREDICATE)
 #undef DECLARE_STRUCT_PREDICATE
 
+  INLINE(bool IsTheHole(Isolate* isolate) const);
+  INLINE(bool IsUndefined(Isolate* isolate) const);
+
   // ES6, section 7.2.2 IsArray.  NOT to be confused with %_IsArray.
   MUST_USE_RESULT static Maybe<bool> IsArray(Handle<Object> object);
 
   INLINE(bool IsNameDictionary() const);
   INLINE(bool IsGlobalDictionary() const);
   INLINE(bool IsSeededNumberDictionary() const);
   INLINE(bool IsUnseededNumberDictionary() const);
   INLINE(bool IsOrderedHashSet() const);
   INLINE(bool IsOrderedHashMap() const);
   static bool IsPromise(Handle<Object> object);
@@ skipping 476 matching lines @@
 
 #define IS_TYPE_FUNCTION_DECL(type_) INLINE(bool Is##type_() const);
   HEAP_OBJECT_TYPE_LIST(IS_TYPE_FUNCTION_DECL)
   ODDBALL_LIST(IS_TYPE_FUNCTION_DECL)
 #undef IS_TYPE_FUNCTION_DECL
 #define DECLARE_STRUCT_PREDICATE(NAME, Name, name) \
   INLINE(bool Is##Name() const);
   STRUCT_LIST(DECLARE_STRUCT_PREDICATE)
 #undef DECLARE_STRUCT_PREDICATE
 
+  INLINE(bool IsTheHole(Isolate* isolate) const);

[Michael Starzinger, 2016/06/06 08:55:08]

The predicates are already declared on the {Object} class and should be
inherited here. Also the implementation of those two is the same. Why do we need
to declare and implement them twice? Could we drop these two?

+  INLINE(bool IsUndefined(Isolate* isolate) const);
+
   // Converts an address to a HeapObject pointer.
   static inline HeapObject* FromAddress(Address address) {
     DCHECK_TAG_ALIGNED(address);
     return reinterpret_cast<HeapObject*>(address + kHeapObjectTag);
   }
 
   // Returns the address of this HeapObject.
   inline Address address() {
     return reinterpret_cast<Address>(this) - kHeapObjectTag;
   }
@@ skipping 2295 matching lines @@
 
   int HashToEntry(int hash) {
     int bucket = HashToBucket(hash);
     Object* entry = this->get(kHashTableStartIndex + bucket);
     return Smi::cast(entry)->value();
   }
 
   int KeyToFirstEntry(Object* key) {
     Object* hash = key->GetHash();
     // If the object does not have an identity hash, it was never used as a key
-    if (hash->IsUndefined()) return kNotFound;
+    if (hash->IsUndefined(GetIsolate())) return kNotFound;
     return HashToEntry(Smi::cast(hash)->value());
   }
 
   int NextChainEntry(int entry) {
     Object* next_entry = get(EntryToIndex(entry) + kChainOffset);
     return Smi::cast(next_entry)->value();
   }
 
-  // use KeyAt(i)->IsTheHole() to determine if this is a deleted entry.
+  // use KeyAt(i)->IsTheHole(isolate) to determine if this is a deleted entry.
   Object* KeyAt(int entry) {
     DCHECK_LT(entry, this->UsedCapacity());
     return get(EntryToIndex(entry));
   }
 
   bool IsObsolete() {
     return !get(kNextTableIndex)->IsSmi();
   }
 
   // The next newer table. This is only valid if the table is obsolete.
@@ skipping 6885 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_