Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

Issue 2028963002: Fixed overlapping subtle notifications on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mac-new-back-shortcut-bubble
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
diff --git a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
index 0b4da465a4e6a1f3497aeab9d280322436ab0477..d2a2bda041dd27d53fc3a7685886bed95f9ff156 100644
--- a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
+++ b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
@@ -34,10 +34,16 @@ ExclusiveAccessController::ExclusiveAccessController(
ExclusiveAccessController::~ExclusiveAccessController() {}
void ExclusiveAccessController::Show() {
+ // Hide the backspace shortcut bubble, to avoid overlapping.
+ new_back_shortcut_bubble_.reset();
+
views_bubble_.reset(new ExclusiveAccessBubbleViews(this, url_, bubble_type_));
}
void ExclusiveAccessController::ShowNewBackShortcutBubble(bool forward) {
+ // Hide the exclusive access bubble, to avoid overlapping.
+ views_bubble_.reset();
+
if (new_back_shortcut_bubble_)
new_back_shortcut_bubble_->UpdateContent(forward);
else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698