Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc

Issue 2028953002: Deprecate NavigationToFirstContentfulPaint.UserGesture reload variant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
index 1ddecc3408d9ea28fac060b536d63259a4624985..6e3a23c886f9ac67c1c39ef5c30f9def41e0a18c 100644
--- a/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
@@ -14,20 +14,16 @@ namespace {
const char kHistogramFirstContentfulPaintReload[] =
"PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint";
-const char kHistogramFirstContentfulPaintReloadByGesture[] =
- "PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint."
- "UserGesture";
} // namespace
ReloadPageLoadMetricsObserver::ReloadPageLoadMetricsObserver()
- : page_transition_was_reload_(false), initiated_by_user_gesture_(false) {}
+ : page_transition_was_reload_(false) {}
void ReloadPageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
page_transition_was_reload_ = ui::PageTransitionCoreTypeIs(
navigation_handle->GetPageTransition(), ui::PAGE_TRANSITION_RELOAD);
- initiated_by_user_gesture_ = navigation_handle->HasUserGesture();
}
void ReloadPageLoadMetricsObserver::OnFirstContentfulPaint(
@@ -41,10 +37,6 @@ void ReloadPageLoadMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReload,
timing.first_contentful_paint);
- if (initiated_by_user_gesture_) {
- PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReloadByGesture,
- timing.first_contentful_paint);
- }
}
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698