Fix color of looking glass when searching on remote NTP.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/i18n/rtl.h"
@@ skipping 847 matching lines @@
 
 void LocationBarView::RefreshLocationIcon() {
   // |omnibox_view_| may not be ready yet if Init() has not been called. The
   // icon will be set soon by OnChanged().
   if (!omnibox_view_)
     return;
 
   if (ui::MaterialDesignController::IsModeMaterial()) {
     const int kIconSize = 16;
     security_state::SecurityStateModel::SecurityLevel security_level =
         GetToolbarModel()->GetSecurityLevel(false);

[Evan Stade, 2016/06/01 02:05:28]

The annoying thing is that toolbar model already takes editing state into
account, but doesn't consider "editing or empty". I spent a while looking at how
to push this editing or empty check further up (into OmniboxView for example)
but I'm wary of what subtle changes might follow on from this as other callsites
start behaving slightly differently.

Also GetSecurityLevel is almost always called with false as the parameter,
there's only one place that true is passed in AFAICT, which is
OmniboxEditModel::ClassifyPage(). This seems unfortunate because most places
that call this don't really care about editing state one way or another.

[Peter Kasting, 2016/06/01 03:18:02]

I looked up the history of "editing or empty" (it was added in
http://crrev.com/44087 ) and after some more digging, I'm convinced that the
toolbar model's GetSecurityState() function should check IsEditingOrEmpty()
instead of checking input_in_progress().  This should work correctly for every
caller I found and would also fix this issue.
The entire idea of caring about editing state is an artifact of search term
replacement, which is dead.  There's been a bug on file about ripping all that
plumbing out for a couple of years now, assigned to groby@, and I now believe
she'll never get to it.  It would sure make a lot of omnibox and toolbar code
much nicer...

     SkColor icon_color =
-        (security_level == security_state::SecurityStateModel::NONE)
+        omnibox_view_->IsEditingOrEmpty() ||
+                (security_level == security_state::SecurityStateModel::NONE)
             ? color_utils::DeriveDefaultIconColor(GetColor(TEXT))
             : GetSecureTextColor(security_level);
     location_icon_view_->SetImage(gfx::CreateVectorIcon(
         omnibox_view_->GetVectorIcon(), kIconSize, icon_color));
   } else {
     location_icon_view_->SetImage(
         *GetThemeProvider()->GetImageSkiaNamed(omnibox_view_->GetIcon()));
   }
 }
 
@@ skipping 508 matching lines @@
 // LocationBarView, private TemplateURLServiceObserver implementation:
 
 void LocationBarView::OnTemplateURLServiceChanged() {
   template_url_service_->RemoveObserver(this);
   template_url_service_ = nullptr;
   // If the browser is no longer active, let's not show the info bubble, as this
   // would make the browser the active window again.
   if (omnibox_view_ && omnibox_view_->GetWidget()->IsActive())
     ShowFirstRunBubble();
 }