Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 202893002: Replace elementHasLegalLinkAttribute() helper with virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/core/html/HTMLImageElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 page->focusController().setFocusedFrame(nullptr); 197 page->focusController().setFocusedFrame(nullptr);
198 } 198 }
199 } 199 }
200 200
201 bool HTMLFrameElementBase::isURLAttribute(const Attribute& attribute) const 201 bool HTMLFrameElementBase::isURLAttribute(const Attribute& attribute) const
202 { 202 {
203 return attribute.name() == longdescAttr || attribute.name() == srcAttr 203 return attribute.name() == longdescAttr || attribute.name() == srcAttr
204 || HTMLFrameOwnerElement::isURLAttribute(attribute); 204 || HTMLFrameOwnerElement::isURLAttribute(attribute);
205 } 205 }
206 206
207 bool HTMLFrameElementBase::hasLegalLinkAttribute(const QualifiedName& name) cons t
208 {
209 return name == hrefAttr || HTMLFrameOwnerElement::hasLegalLinkAttribute(name );
210 }
211
207 bool HTMLFrameElementBase::isHTMLContentAttribute(const Attribute& attribute) co nst 212 bool HTMLFrameElementBase::isHTMLContentAttribute(const Attribute& attribute) co nst
208 { 213 {
209 return attribute.name() == srcdocAttr || HTMLFrameOwnerElement::isHTMLConten tAttribute(attribute); 214 return attribute.name() == srcdocAttr || HTMLFrameOwnerElement::isHTMLConten tAttribute(attribute);
210 } 215 }
211 216
212 int HTMLFrameElementBase::width() 217 int HTMLFrameElementBase::width()
213 { 218 {
214 document().updateLayoutIgnorePendingStylesheets(); 219 document().updateLayoutIgnorePendingStylesheets();
215 if (!renderBox()) 220 if (!renderBox())
216 return 0; 221 return 0;
217 return renderBox()->width(); 222 return renderBox()->width();
218 } 223 }
219 224
220 int HTMLFrameElementBase::height() 225 int HTMLFrameElementBase::height()
221 { 226 {
222 document().updateLayoutIgnorePendingStylesheets(); 227 document().updateLayoutIgnorePendingStylesheets();
223 if (!renderBox()) 228 if (!renderBox())
224 return 0; 229 return 0;
225 return renderBox()->height(); 230 return renderBox()->height();
226 } 231 }
227 232
228 } // namespace WebCore 233 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameElementBase.h ('k') | Source/core/html/HTMLImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698