Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2028923002: [Android] Add five APK targets to gn_all. (RELAND) (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add five APK targets to gn_all. (RELAND) This is a reland of https://codereview.chromium.org/2024923002/ BUG= Committed: https://crrev.com/dfc01f67d85e68c2e13ae7d96591f89d3c084f88 Cr-Commit-Position: refs/heads/master@{#397151}

Patch Set 1 : original #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M BUILD.gn View 1 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
Verified: - linker tests build and pass on a cast build - gn_all builds successfully ...
4 years, 6 months ago (2016-06-01 02:17:18 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 03:26:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028923002/20001
4 years, 6 months ago (2016-06-01 13:55:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 15:42:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 15:44:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dfc01f67d85e68c2e13ae7d96591f89d3c084f88
Cr-Commit-Position: refs/heads/master@{#397151}

Powered by Google App Engine
This is Rietveld 408576698