content/browser/frame_host/frame_tree_node_blame_context.cc - Issue 2028913003: Renaming in traced FrameTreeNodeBlameContext snapshot's argument name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree_node_blame_context.cc

Issue 2028913003: Renaming in traced FrameTreeNodeBlameContext snapshot's argument name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/frame_tree_node_blame_context.cc

diff --git a/content/browser/frame_host/frame_tree_node_blame_context.cc b/content/browser/frame_host/frame_tree_node_blame_context.cc

index fb993be85b58dbd6c00ad8bc3b98bff1a098c9d5..bae5f2a03684efca40939edeabfdf20633d5d0c7 100644

--- a/content/browser/frame_host/frame_tree_node_blame_context.cc

+++ b/content/browser/frame_host/frame_tree_node_blame_context.cc

@@ -56,7 +56,7 @@ void FrameTreeNodeBlameContext::AsValueInto(

int routing_id = current_frame_host->GetRoutingID();

DCHECK_NE(routing_id, MSG_ROUTING_NONE);

- value->BeginDictionary(kRenderFrameBlameContextScope);

+ value->BeginDictionary("renderFrame");

Sami 2016/06/01 09:11:48 nit: render_frame to match the other properties he

value->SetInteger("pid_ref", process_id);

value->SetString("id_ref", base::StringPrintf("0x%x", routing_id));

value->SetString("scope", kRenderFrameBlameContextScope);

« no previous file with comments | « no previous file | no next file » | no next file with comments »