Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2028913003: Renaming in traced FrameTreeNodeBlameContext snapshot's argument name (Closed)

Created:
4 years, 6 months ago by Xiaocheng
Modified:
4 years, 6 months ago
Reviewers:
clamy, Sami
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming in traced FrameTreeNodeBlameContext snapshot's argument name A traced value's argument name is changed from "RenderFrame" to "renderFrame", to be better consistent with the naming style in Trace Viewer. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/7cee1e976a770ec9a99022824ca99d0114774e7f Cr-Commit-Position: refs/heads/master@{#397293}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/frame_tree_node_blame_context.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028913003/1
4 years, 6 months ago (2016-06-01 05:06:25 UTC) #3
Xiaocheng
Just a minor change in the naming style. PTAL.
4 years, 6 months ago (2016-06-01 05:07:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 06:39:09 UTC) #7
Sami
lgtm with a nit. https://codereview.chromium.org/2028913003/diff/1/content/browser/frame_host/frame_tree_node_blame_context.cc File content/browser/frame_host/frame_tree_node_blame_context.cc (right): https://codereview.chromium.org/2028913003/diff/1/content/browser/frame_host/frame_tree_node_blame_context.cc#newcode59 content/browser/frame_host/frame_tree_node_blame_context.cc:59: value->BeginDictionary("renderFrame"); nit: render_frame to match ...
4 years, 6 months ago (2016-06-01 09:11:48 UTC) #8
Xiaocheng
On 2016/06/01 at 09:11:48, skyostil wrote: > lgtm with a nit. Thanks. > > https://codereview.chromium.org/2028913003/diff/1/content/browser/frame_host/frame_tree_node_blame_context.cc ...
4 years, 6 months ago (2016-06-01 09:19:20 UTC) #9
clamy
rs lgtm
4 years, 6 months ago (2016-06-01 13:08:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028913003/1
4 years, 6 months ago (2016-06-02 01:48:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 02:09:57 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 02:11:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cee1e976a770ec9a99022824ca99d0114774e7f
Cr-Commit-Position: refs/heads/master@{#397293}

Powered by Google App Engine
This is Rietveld 408576698