Issue 20289002: Android: further fixes to bb_device_status_check.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20289002: Android: further fixes to bb_device_status_check.py (Closed)

Created:
7 years, 5 months ago by bulach

Modified:
7 years, 5 months ago

Reviewers:
Tom Hudson, navabi1, tomhudson

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: further fixes to bb_device_status_check.py There's no guarantees about the data coming from the device: instead of expecting them to be there, mark them as Unknown. BUG=254014 R=tomhudson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213635

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	build/android/buildbot/bb_device_status_check.py	View		1 chunk	+17 lines, -18 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tomhudson

lgtm https://codereview.chromium.org/20289002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/20289002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode49 build/android/buildbot/bb_device_status_check.py:49: def _GetData(re_expression, line, lambda_function=lambda x:x): lambdas? Ooh, fancy!

7 years, 5 months ago (2013-07-25 11:25:20 UTC) #2

bulach

7 years, 5 months ago (2013-07-25 15:39:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r213635 (presubmit successful).

Expand Messages | Collapse Messages