Disallow fragmentation of composited content.

Disallow fragmentation of composited content.

BUG=616287
Committed: https://crrev.com/d88f5fb93af61fdb863c0cbd1bfcfa24873b50d4
Cr-Commit-Position: refs/heads/master@{#397515}

[chrishtr, 2016-05-31 23:45:53]

Description was changed from

==========
none

BUG=
==========

to

==========
Disallow fragmentation of composited content.

BUG=616287
==========

[chrishtr, 2016-06-02 03:48:29]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 03:48:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028893002/60001

[commit-bot: I haz the power, 2016-06-02 04:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:06:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-06-02 14:05:09]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 14:05:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028893002/60001

[commit-bot: I haz the power, 2016-06-02 15:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 15:33:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-06-02 16:14:13]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2016-06-02 16:14:14]

See patch set 4 for a CQ run without the reftests removed. It might be most
useful to
go through the changes in person to explain them.

fast/multicol/composited-inner-multicol.html will be fixed by SPv2 because it
involves indirect
compositing due to overlap. In SPv2 this will happen post-paint by fragmenting
the display
list, so nothing will have to change position like this.

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/multicol/composited-inner-multicol-expected.html
(left):

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/multicol/composited-inner-multicol-expected.html:2:
<p>Below you should see the word 'PASS' (with some extra letter spacing), on a
yellow background
I felt it would be better to just remove the reftests and rebaseline in this
case, rather than spending
a bunch of time rewriting these expectation files.

[wkorman, 2016-06-02 18:04:15]

lgtm

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:58: crbug.com/616287
fast/multicol/composited-inner-multicol.html [ NeedsRebaseline ]
Need to update text in tests:

fast/multicol/composited-relpos-clipped.html
fast/multicol/composited-relpos-in-clipped.html
fast/multicol/composited-relpos-resize.html
fast/multicol/composited-relpos.html
fast/multicol/composited-with-child-layer-in-next-column.html
fast/multicol/composited-with-overflow-in-next-column.html
fast/multicol/span/invalid-spanner-in-transform.html

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:1495: return
enclosingPaginationLayer() && !compositingLayer->enclosingPaginationLayer();
Considering whether a comment to explain this further is warranted here or
elsewhere, re:

https://groups.google.com/a/chromium.org/d/msg/paint-dev/uQF-DlRlf1k/EDXipWUO...

[chrishtr, 2016-06-02 18:22:44]

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:58: crbug.com/616287
fast/multicol/composited-inner-multicol.html [ NeedsRebaseline ]
On 2016/06/02 at 18:04:15, wkorman wrote:
> Need to update text in tests:
> 
> fast/multicol/composited-relpos-clipped.html
> fast/multicol/composited-relpos-in-clipped.html
> fast/multicol/composited-relpos-resize.html
> fast/multicol/composited-relpos.html
> fast/multicol/composited-with-child-layer-in-next-column.html
> fast/multicol/composited-with-overflow-in-next-column.html
> fast/multicol/span/invalid-spanner-in-transform.html

Done.

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2028893002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:1495: return
enclosingPaginationLayer() && !compositingLayer->enclosingPaginationLayer();
On 2016/06/02 at 18:04:15, wkorman wrote:
> Considering whether a comment to explain this further is warranted here or
elsewhere, re:
> 
>
https://groups.google.com/a/chromium.org/d/msg/paint-dev/uQF-DlRlf1k/EDXipWUO...

Done.

[chrishtr, 2016-06-02 18:23:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-06-02 18:23:13]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2028893002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 18:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028893002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028893002/120001

[commit-bot: I haz the power, 2016-06-02 21:41:57]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-02 21:44:34]

Description was changed from

==========
Disallow fragmentation of composited content.

BUG=616287
==========

to

==========
Disallow fragmentation of composited content.

BUG=616287

Committed: https://crrev.com/d88f5fb93af61fdb863c0cbd1bfcfa24873b50d4
Cr-Commit-Position: refs/heads/master@{#397515}
==========

[commit-bot: I haz the power, 2016-06-02 21:44:36]

Patchset 7 (id:??) landed as
https://crrev.com/d88f5fb93af61fdb863c0cbd1bfcfa24873b50d4
Cr-Commit-Position: refs/heads/master@{#397515}