chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove retain Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm ('K') | « chrome/browser/notifications/notification_builder_mac.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm » ('j') | device/bluetooth/test/bluetooth_test_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

diff --git a/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm b/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

index f51cba6881962b0be728d3671a20ef40124139be..24d8254396328e3acb91abdb8f0d4f2ed0e6ae95 100644

--- a/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

+++ b/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

@@ -473,7 +473,7 @@ - (void)createStorageViewWithController:

storageView_.reset([[NSView alloc] initWithFrame:NSZeroRect]);

[storageView_ setAutoresizingMask:NSViewWidthSizable];

- base::scoped_nsobject<NSBox> box = [CardUnmaskPromptViewCocoa createPlainBox];

+ base::scoped_nsobject<NSBox> box([CardUnmaskPromptViewCocoa createPlainBox]);

[box setAutoresizingMask:NSViewWidthSizable];

[box setFillColor:skia::SkColorToCalibratedNSColor(kShadingColor)];

[box setContentViewMargins:NSMakeSize(chrome_style::kHorizontalPadding,

@@ -506,8 +506,8 @@ - (void)createStorageViewWithController:

NSMakePoint(NSMaxX([storageCheckbox_ frame]) + kButtonGap, 0)];

// Add horizontal separator.

- base::scoped_nsobject<NSBox> separator =

- [CardUnmaskPromptViewCocoa createPlainBox];

+ base::scoped_nsobject<NSBox> separator(

+ [CardUnmaskPromptViewCocoa createPlainBox]);

[separator setAutoresizingMask:NSViewWidthSizable];

[separator setFillColor:skia::SkColorToCalibratedNSColor(kSubtleBorderColor)];

[storageView_ addSubview:separator];