chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm

index 5e0c932cc3e58a022930c991f0f900155bc90340..f1be28c9186b704a336e1754bc61b046987c976e 100644

--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm

@@ -128,8 +128,8 @@ - (void)loadView {

kDesiredBubbleWidth,

std::min<CGFloat>([credentialButtons_ count], kMaxHeightAccounts) *

kCredentialHeight);

- base::scoped_nsobject<NSScrollView> scrollView = [[NSScrollView alloc]

- initWithFrame:NSMakeRect(0, 0, buttonsSize.width, buttonsSize.height)];

+ base::scoped_nsobject<NSScrollView> scrollView([[NSScrollView alloc]

+ initWithFrame:NSMakeRect(0, 0, buttonsSize.width, buttonsSize.height)]);

[scrollView

setHasVerticalScroller:[credentialButtons_ count] > kMaxHeightAccounts

? YES

« no previous file with comments | « chrome/browser/ui/cocoa/new_tab_button.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_view.mm » ('j') | device/bluetooth/test/bluetooth_test_mac.mm » ('J')