ios/chrome/browser/passwords/password_controller_unittest.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/password_controller_unittest.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm ('k') | ios/web/web_state/web_state_delegate_bridge_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/password_controller_unittest.mm

diff --git a/ios/chrome/browser/passwords/password_controller_unittest.mm b/ios/chrome/browser/passwords/password_controller_unittest.mm

index 70c19cc3474f46eeba4dc4b1c783c7ab952379eb..7757fe291c68abe8b21a1ed81c1a441ba1326487 100644

--- a/ios/chrome/browser/passwords/password_controller_unittest.mm

+++ b/ios/chrome/browser/passwords/password_controller_unittest.mm

@@ -72,10 +72,10 @@ void SetSuspended(bool suspended) override {}

.WillByDefault(testing::Return(browser_state.get()));

auto client = base::WrapUnique(new MockPasswordManagerClient);

MockPasswordManagerClient* weak_client = client.get();

- base::scoped_nsobject<PasswordController> passwordController =

+ base::scoped_nsobject<PasswordController> passwordController(

[[PasswordController alloc] initWithWebState:&web_state

passwordsUiDelegate:nil

- client:std::move(client)];

+ client:std::move(client)]);

// Use a mock LogManager to detect that OnPasswordFormsRendered has been

// called. TODO(crbug.com/598672): this is a hack, we should modularize the