components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

diff --git a/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm b/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

index ac62051013c7e4b8072ca031029c4557ba4394e9..75a5e7f7fa74cc03e6e7f6ad2a3d8d10ff3c114e 100644

--- a/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

+++ b/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

@@ -228,7 +228,7 @@ void FillFlattenedArraysForBookmarks(

}

if (!item) {

- item = [[NSPasteboardItem alloc] init];

+ item.reset([[NSPasteboardItem alloc] init]);

}

[item setString:[toplevel_string_data componentsJoinedByString:@"\n"]

« no previous file with comments | « chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm ('k') | device/bluetooth/test/bluetooth_test_mac.mm » ('j') | no next file with comments »