chrome/browser/ui/cocoa/tabs/tab_view.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_view.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_view.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_view.mm b/chrome/browser/ui/cocoa/tabs/tab_view.mm

index 27066e711e5d4c555d36fc460b79ea23ef583ce5..ea826ff8b463931d0e02afe74c6a1c385d8b300a 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_view.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_view.mm

@@ -91,10 +91,9 @@ - (HoverCloseButton*)closeButton;

}

DCHECK(theSelector);

- base::scoped_nsobject<NSCustomImageRep> imageRep =

- [[NSCustomImageRep alloc]

- initWithDrawSelector:theSelector

- delegate:[TabView class]];

+ base::scoped_nsobject<NSCustomImageRep> imageRep([[NSCustomImageRep alloc]

+ initWithDrawSelector:theSelector

+ delegate:[TabView class]]);

NSImage* newTabButtonImage =

[[[NSImage alloc] initWithSize:NSMakeSize(imageWidth, 29)] autorelease];