chrome/browser/ui/cocoa/new_tab_button.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/new_tab_button.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/new_tab_button.mm

diff --git a/chrome/browser/ui/cocoa/new_tab_button.mm b/chrome/browser/ui/cocoa/new_tab_button.mm

index f3823f6119f386a9a0c85f81c98b0dad3b75a8dc..5d32e083ed6e9f6611dfd13856133fd5f4e56e41 100644

--- a/chrome/browser/ui/cocoa/new_tab_button.mm

+++ b/chrome/browser/ui/cocoa/new_tab_button.mm

@@ -359,10 +359,10 @@ - (NSImage*)imageForState:(image_button_cell::ButtonState)state

NOTREACHED();

}

- base::scoped_nsobject<NewTabButtonCustomImageRep> imageRep =

+ base::scoped_nsobject<NewTabButtonCustomImageRep> imageRep(

[[NewTabButtonCustomImageRep alloc]

initWithDrawSelector:@selector(drawNewTabButtonImage:)

- delegate:[NewTabButton class]];

+ delegate:[NewTabButton class]]);

[imageRep setDestView:self];

[imageRep setFillColor:fillColor];

[imageRep setPatternPhasePosition: