chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h

index 72656f1684c913530f41b9833590a720c6c561c1..433737350a338d6aeb0c67efbd69180a9a03bcc7 100644

--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h

@@ -45,8 +45,8 @@ class ChooserDialogCocoa : public ConstrainedWindowMacDelegate,

private:

friend class ChooserDialogCocoaControllerTest;

base::scoped_nsobject<ChooserDialogCocoaController>

- chooser_dialog_cocoa_controller_ = nullptr;

- std::unique_ptr<ConstrainedWindowMac> constrained_window_ = nullptr;

+ chooser_dialog_cocoa_controller_;

+ std::unique_ptr<ConstrainedWindowMac> constrained_window_;

content::WebContents* web_contents_; // Weak.

ChooserController* chooser_controller_; // Weak.

};