Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: blimp/engine/app/blimp_content_browser_client.h

Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to mvanouwerkerk's #21-1, #26 (partial) comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_content_browser_client.h
diff --git a/blimp/engine/app/blimp_content_browser_client.h b/blimp/engine/app/blimp_content_browser_client.h
index ab5e89578e5d1e634a3e13afc166cfe3a05ab1d5..0cb0dae86e3d16b11618b819c5e11d36588aaba9 100644
--- a/blimp/engine/app/blimp_content_browser_client.h
+++ b/blimp/engine/app/blimp_content_browser_client.h
@@ -6,6 +6,7 @@
#define BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_
#include "base/macros.h"
+#include "blimp/engine/feature/geolocation/blimp_location_provider.h"
#include "content/public/browser/content_browser_client.h"
namespace blimp {
@@ -30,6 +31,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
content::WebPreferences* prefs) override;
void RegisterRenderProcessMojoServices(
content::ServiceRegistry* registry) override;
+ content::LocationProvider* OverrideSystemLocationProvider() override;
+ bool UseDefaultLocationProviders() override;
Wez 2016/06/01 21:45:19 nit: Are there "default" location providers beside
CJ 2016/06/01 22:37:10 Done.
BlimpBrowserContext* GetBrowserContext();
@@ -37,6 +40,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
// Owned by BrowserMainLoop
BlimpBrowserMainParts* blimp_browser_main_parts_ = nullptr;
+ std::unique_ptr<BlimpLocationProvider> location_provider_;
+
DISALLOW_COPY_AND_ASSIGN(BlimpContentBrowserClient);
};

Powered by Google App Engine
This is Rietveld 408576698