Refactor to make BlimpLocationProvider accessible to content layer.

blimp/engine/app/blimp_content_browser_client.h

Index: blimp/engine/app/blimp_content_browser_client.h
diff --git a/blimp/engine/app/blimp_content_browser_client.h b/blimp/engine/app/blimp_content_browser_client.h
index ab5e89578e5d1e634a3e13afc166cfe3a05ab1d5..2dbdd26ce851572b8f623b6f65a955009c6f021c 100644
--- a/blimp/engine/app/blimp_content_browser_client.h
+++ b/blimp/engine/app/blimp_content_browser_client.h
@@ -6,6 +6,7 @@
 #define BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_
 
 #include "base/macros.h"
+#include "blimp/engine/feature/geolocation/blimp_location_provider.h"
 #include "content/public/browser/content_browser_client.h"
 
 namespace blimp {
@@ -30,6 +31,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
                            content::WebPreferences* prefs) override;
   void RegisterRenderProcessMojoServices(
       content::ServiceRegistry* registry) override;
+  content::LocationProvider* OverrideSystemLocationProvider() override;
+  bool UseDefaultLocationProviders() override;
 
   BlimpBrowserContext* GetBrowserContext();
 
@@ -37,6 +40,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
   // Owned by BrowserMainLoop
   BlimpBrowserMainParts* blimp_browser_main_parts_ = nullptr;
 
+  BlimpLocationProvider location_provider_;

[Michael van Ouwerkerk, 2016/06/01 15:57:35]

I'm not sure that this actually works correctly as a value member right now. It
means the provider is always instantiated, even when not needed, and its
destructor calls StopProvider which says NOTIMPLEMENTED. Isn't this crashing at
every shutdown?

I'd suggest keeping an std::unique_ptr<BlimpLocationProvider> and instantiating
one lazily when needed. That would also make it easier to e.g. insert a fake in
tests.

[CJ, 2016/06/01 21:04:53]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(BlimpContentBrowserClient);
 };