blimp/engine/feature/geolocation/blimp_location_provider.cc - Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.cc

Issue 2028823002: Refactor to make BlimpLocationProvider accessible to content layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes to address kmarshall's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/app/blimp_content_browser_client.h ('K') | « blimp/engine/app/blimp_content_browser_client.cc ('k') | content/browser/geolocation/location_arbitrator_impl.cc » ('j') | content/browser/geolocation/location_arbitrator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/feature/geolocation/blimp_location_provider.cc

diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.cc b/blimp/engine/feature/geolocation/blimp_location_provider.cc

index 23a9a7f0e51b39b2c799e6242e6dc421ed3566da..9aaa796d225f9b6199e13d5f1abf49bd26d79efc 100644

--- a/blimp/engine/feature/geolocation/blimp_location_provider.cc

+++ b/blimp/engine/feature/geolocation/blimp_location_provider.cc

@@ -9,9 +9,7 @@

namespace blimp {

namespace engine {

-BlimpLocationProvider::BlimpLocationProvider() {

- NOTIMPLEMENTED();

+BlimpLocationProvider::BlimpLocationProvider() {}

BlimpLocationProvider::~BlimpLocationProvider() {

StopProvider();