Refactor to make BlimpLocationProvider accessible to content layer.

blimp/engine/app/blimp_content_browser_client.h

Index: blimp/engine/app/blimp_content_browser_client.h
diff --git a/blimp/engine/app/blimp_content_browser_client.h b/blimp/engine/app/blimp_content_browser_client.h
index ab5e89578e5d1e634a3e13afc166cfe3a05ab1d5..24e3896ccadccbf6883206a3b38b877db34f0946 100644
--- a/blimp/engine/app/blimp_content_browser_client.h
+++ b/blimp/engine/app/blimp_content_browser_client.h
@@ -6,6 +6,7 @@
 #define BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_
 
 #include "base/macros.h"
+#include "blimp/engine/feature/geolocation/blimp_location_provider.h"

[Michael van Ouwerkerk, 2016/06/10 12:46:52]

nit: you could forward declare BlimpLocationProvider and include this in the cc
file.

[CJ, 2016/06/10 19:51:34]

I thought convention was to have the include in the same file in which its
contents are referenced? 

[Michael van Ouwerkerk, 2016/06/14 16:46:42]

You're right, it is. However, it's also convention to use forward declarations
in headers, as is done here for BlimpBrowserMainParts and BlimpBrowserContext. I
mean, BlimpLocationProvider is not really used in this file is it, just referred
to?

[CJ, 2016/06/21 21:27:41]

Ah, so if it is just referred to, as in with a member variable, then we just
include it in the cc file? 

Done. 

[CJ, 2016/06/22 21:48:58]

This change did not pass try. Reverting back to the original import in the
header.

 #include "content/public/browser/content_browser_client.h"
 
 namespace blimp {
@@ -30,6 +31,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
                            content::WebPreferences* prefs) override;
   void RegisterRenderProcessMojoServices(
       content::ServiceRegistry* registry) override;
+  content::LocationProvider* OverrideSystemLocationProvider() override;
+  bool UseNetworkLocationProviders() override;
 
   BlimpBrowserContext* GetBrowserContext();
 
@@ -37,6 +40,8 @@ class BlimpContentBrowserClient : public content::ContentBrowserClient {
   // Owned by BrowserMainLoop
   BlimpBrowserMainParts* blimp_browser_main_parts_ = nullptr;
 
+  std::unique_ptr<BlimpLocationProvider> location_provider_;
+
   DISALLOW_COPY_AND_ASSIGN(BlimpContentBrowserClient);
 };