Refactor to make BlimpLocationProvider accessible to content layer.

blimp/engine/app/blimp_content_browser_client.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_
 #define BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_
 
 #include "base/macros.h"
+#include "blimp/engine/feature/geolocation/blimp_location_provider.h"
 #include "content/public/browser/content_browser_client.h"
 
 namespace blimp {
 namespace engine {
 
 class BlimpBrowserMainParts;
 class BlimpBrowserContext;
 
 class BlimpContentBrowserClient : public content::ContentBrowserClient {
  public:
   BlimpContentBrowserClient();
   ~BlimpContentBrowserClient() override;
 
   BlimpBrowserMainParts* blimp_browser_main_parts() {
     return blimp_browser_main_parts_;
   }
 
   // content::ContentBrowserClient implementation.
   content::BrowserMainParts* CreateBrowserMainParts(
       const content::MainFunctionParams& parameters) override;
   void OverrideWebkitPrefs(content::RenderViewHost* render_view_host,
                            content::WebPreferences* prefs) override;
   void RegisterRenderProcessMojoServices(
       content::ServiceRegistry* registry) override;
 
   BlimpBrowserContext* GetBrowserContext();
 
+  content::LocationProvider* GetSoleLocationProvider() override;

[Kevin M, 2016/05/31 22:42:55]

The implementation is the same as OverrideSystemLocationProvider, but with
subtly different semantics that must be obeyed by the caller. What if we just
expressed those semantics specifically via a getter interface? Like e.g. have a
virtual bool "UseDefaultLocationProviders()" that would return true by default
in the base class, but would be overridden to return false for the
BlimpContentBrowserClient.

We would use the same OverrideSystemLocationProvider() method in that case.

+
  private:
   // Owned by BrowserMainLoop
   BlimpBrowserMainParts* blimp_browser_main_parts_ = nullptr;
 
+  BlimpLocationProvider location_provider_;
+
   DISALLOW_COPY_AND_ASSIGN(BlimpContentBrowserClient);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_APP_BLIMP_CONTENT_BROWSER_CLIENT_H_