Refactor to make BlimpLocationProvider accessible to content layer.

content/browser/geolocation/location_arbitrator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/location_arbitrator_impl.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 34 matching lines @@
   return GURL(kDefaultNetworkProviderUrl);
 }
 
 void LocationArbitratorImpl::OnPermissionGranted() {
   is_permission_granted_ = true;
   for (const auto& provider : providers_)
     provider->OnPermissionGranted();
 }
 
 void LocationArbitratorImpl::StartProviders(bool enable_high_accuracy) {
-  // GetAccessTokenStore() will return NULL for embedders not implementing
-  // the AccessTokenStore class, so we report an error to avoid JavaScript
-  // requests of location to wait eternally for a reply.
-  AccessTokenStore* access_token_store = GetAccessTokenStore();
-  if (!access_token_store) {
-    Geoposition position;
-    position.error_code = Geoposition::ERROR_CODE_PERMISSION_DENIED;
-    arbitrator_update_callback_.Run(position);
-    return;
-  }
-
   // Stash options as OnAccessTokenStoresLoaded has not yet been called.
   is_running_ = true;
   enable_high_accuracy_ = enable_high_accuracy;
+
   if (providers_.empty()) {
-    DCHECK(DefaultNetworkProviderURL().is_valid());
-    access_token_store->LoadAccessTokens(
-        base::Bind(&LocationArbitratorImpl::OnAccessTokenStoresLoaded,
-                   base::Unretained(this)));
+    if (GetContentClient()->browser()->UseNetworkLocationProviders()) {
+      // GetAccessTokenStore() will return NULL for embedders not implementing
+      // the AccessTokenStore class, so we report an error to avoid JavaScript
+      // requests of location to wait eternally for a reply.
+      AccessTokenStore* access_token_store = GetAccessTokenStore();
+      if (!access_token_store) {
+        Geoposition position;
+        position.error_code = Geoposition::ERROR_CODE_PERMISSION_DENIED;
+        arbitrator_update_callback_.Run(position);
+        return;

[Kevin M, 2016/06/09 20:36:44]

What about loading the system providers instead of aborting completely?

[CJ, 2016/06/09 23:07:06]

Done.

+      }
+      DCHECK(DefaultNetworkProviderURL().is_valid());
+      access_token_store->LoadAccessTokens(
+          base::Bind(&LocationArbitratorImpl::OnAccessTokenStoresLoaded,
+                     base::Unretained(this)));
+    } else {

[Kevin M, 2016/06/09 20:36:44]

Should this be an "else"? Aren't the network location providers loaded in
addition to the system provider?

[CJ, 2016/06/09 23:07:06]

Done.

+      RegisterSystemProvider();
+    }
   } else {
     DoStartProviders();
   }
 }
 
 void LocationArbitratorImpl::DoStartProviders() {
   for (const auto& provider : providers_)
     provider->StartProvider(enable_high_accuracy_);
 }
 
 void LocationArbitratorImpl::StopProviders() {
   // Reset the reference location state (provider+position)
   // so that future starts use fresh locations from
   // the newly constructed providers.
   position_provider_ = NULL;
   position_ = Geoposition();
 
   providers_.clear();
   is_running_ = false;
 }
 
+void LocationArbitratorImpl::RegisterSystemProvider() {

[Michael van Ouwerkerk, 2016/06/09 13:03:10]

Please keep the same order as in the header, so this method goes below
RegisterProvider.

[CJ, 2016/06/09 20:31:50]

Done.

+  LocationProvider* provider =
+      GetContentClient()->browser()->OverrideSystemLocationProvider();
+  if (!provider)
+    provider = NewSystemLocationProvider();
+  RegisterProvider(provider);
+  DoStartProviders();

[Michael van Ouwerkerk, 2016/06/09 13:03:10]

I don't think DoStartProviders should be called form a method called
RegisterSystemProvider, it is unexpected and does not match the behavior of
RegisterProvider. You should probably just call DoStartProviders when it is
needed from StartProviders or OnAccessTokenStoresLoaded.

[CJ, 2016/06/09 20:31:50]

Done.

+}
+
 void LocationArbitratorImpl::OnAccessTokenStoresLoaded(
     AccessTokenStore::AccessTokenMap access_token_map,
     net::URLRequestContextGetter* context_getter) {
   if (!is_running_ || !providers_.empty()) {
     // A second StartProviders() call may have arrived before the first
     // completed.
     return;
   }
-  LocationProvider* sole_provider =
-      GetContentClient()->browser()->SoleLocationProvider();
-  if (!sole_provider) {
+  if (GetContentClient()->browser()->UseNetworkLocationProviders()) {
     // If there are no access tokens, boot strap it with the default server URL.
     if (access_token_map.empty())
       access_token_map[DefaultNetworkProviderURL()];
     for (const auto& entry : access_token_map) {
       RegisterProvider(NewNetworkLocationProvider(
           GetAccessTokenStore(), context_getter, entry.first, entry.second));
     }
-
-    LocationProvider* provider =
-        GetContentClient()->browser()->OverrideSystemLocationProvider();
-    if (!provider)
-      provider = NewSystemLocationProvider();
-    RegisterProvider(provider);
-  } else {
-    RegisterProvider(sole_provider);
   }
-  DoStartProviders();
+  RegisterSystemProvider();

[Kevin M, 2016/06/09 20:36:44]

Do we need to register system providers in this call, or can we do it before we
kick off the async token fetch?

[CJ, 2016/06/09 23:07:06]

Done.

 }
 
 void LocationArbitratorImpl::RegisterProvider(
     LocationProvider* provider) {
   if (!provider)
     return;
   provider->SetUpdateCallback(provider_update_callback_);
   if (is_permission_granted_)
     provider->OnPermissionGranted();
   providers_.push_back(provider);
@@ skipping 71 matching lines @@
     }
   }
   return false;
 }
 
 bool LocationArbitratorImpl::HasPermissionBeenGranted() const {
   return is_permission_granted_;
 }
 
 }  // namespace content