Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2028803002: Move kDeprecatedQuicErrorCode and kActiveQuicErrorCode to domain_reliability to keep (Closed)

Created:
4 years, 6 months ago by Zhongyi Shi
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move kDeprecatedQuicErrorCode and kActiveQuicErrorCode to domain_reliability to keep quic_protocol.h clean of chromium only code. BUG= Committed: https://crrev.com/c47bd31d5ac1fb5bcfb5aac4cdb8cd42ef400ab8 Cr-Commit-Position: refs/heads/master@{#396939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M components/domain_reliability/quic_error_mapping.cc View 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zhongyi Shi
4 years, 6 months ago (2016-05-31 19:42:24 UTC) #2
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-05-31 19:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028803002/1
4 years, 6 months ago (2016-05-31 20:17:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 21:43:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:45:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c47bd31d5ac1fb5bcfb5aac4cdb8cd42ef400ab8
Cr-Commit-Position: refs/heads/master@{#396939}

Powered by Google App Engine
This is Rietveld 408576698