Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2028793002: Fix reading of menus. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reading of menus. This broke because menuItems are not the descendants of the currently focused item. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bea532204622040e52bdf452fef798dd4fa4c6cd Cr-Commit-Position: refs/heads/master@{#396959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
David Tseng
4 years, 6 months ago (2016-05-31 19:38:27 UTC) #3
dmazzoni
lgtm
4 years, 6 months ago (2016-05-31 21:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028793002/1
4 years, 6 months ago (2016-05-31 22:40:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 22:47:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:50:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bea532204622040e52bdf452fef798dd4fa4c6cd
Cr-Commit-Position: refs/heads/master@{#396959}

Powered by Google App Engine
This is Rietveld 408576698