Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/task_management/providers/task.cc

Issue 2028753002: Make Task Manager sort more meaningful (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/task.cc
diff --git a/chrome/browser/task_management/providers/task.cc b/chrome/browser/task_management/providers/task.cc
index f831ec85ac84c541c82976f029345c82dff78555..59f75e38adac53ab538cb04f8b33786767b39b0f 100644
--- a/chrome/browser/task_management/providers/task.cc
+++ b/chrome/browser/task_management/providers/task.cc
@@ -24,11 +24,11 @@ int64_t g_last_id = 0;
} // namespace
-
Task::Task(const base::string16& title,
const std::string& rappor_sample,
const gfx::ImageSkia* icon,
- base::ProcessHandle handle)
+ base::ProcessHandle handle,
+ base::ProcessId process_id)
: task_id_(g_last_id++),
network_usage_(-1),
current_byte_count_(-1),
@@ -36,11 +36,11 @@ Task::Task(const base::string16& title,
rappor_sample_name_(rappor_sample),
icon_(icon ? *icon : gfx::ImageSkia()),
process_handle_(handle),
- process_id_(base::GetProcId(handle)) {
-}
+ process_id_(process_id != base::kNullProcessId
+ ? process_id
+ : base::GetProcId(handle)) {}
-Task::~Task() {
-}
+Task::~Task() {}
// static
base::string16 Task::GetProfileNameFromProfile(Profile* profile) {
@@ -107,6 +107,14 @@ int Task::GetTabId() const {
return -1;
}
+bool Task::HasParentTask() const {
+ return GetParentTask() != nullptr;
+}
+
+const Task* Task::GetParentTask() const {
+ return nullptr;
+}
+
bool Task::ReportsSqliteMemory() const {
return GetSqliteMemoryUsed() != -1;
}
« no previous file with comments | « chrome/browser/task_management/providers/task.h ('k') | chrome/browser/task_management/providers/web_contents/subframe_task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698