Make Task Manager sort more meaningful

chrome/browser/task_management/providers/task.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_
 #define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 10 matching lines @@
 
 namespace task_management {
 
 // Defines a task that corresponds to a tab, an app, an extension, ... etc. It
 // represents one row in the task manager table. Multiple tasks can share the
 // same process, in which case they're grouped together in the task manager
 // table. See |task_management::TaskGroup| which represents a process possibly
 // shared by multiple tasks.
 class Task {
  public:
+  // Note that the declaration order here determines the default sort order
+  // in the task manager.
   enum Type {
     UNKNOWN = 0,
-    BROWSER,        /* The main browser process. */
-    RENDERER,       /* A normal WebContents renderer process. */
-    EXTENSION,      /* An extension or app process. */
+
+    /* Singleton processes first that don't belong to a particular tab. */
+    BROWSER, /* The main browser process. */
+    GPU,     /* A graphics process. */
+    ARC,     /* An ARC process. */
+    ZYGOTE,  /* A Linux zygote process. */
+    UTILITY, /* A browser utility process. */
+
+    /* Per-Tab processes next. */
+    RENDERER,  /* A normal WebContents renderer process. */
+    EXTENSION, /* An extension or app process. */
+
+    /* Plugin processes last.*/
     GUEST,          /* A browser plugin guest process. */
     PLUGIN,         /* A plugin process. */
     WORKER,         /* A web worker process. */
     NACL,           /* A NativeClient loader or broker process. */
-    UTILITY,        /* A browser utility process. */
-    ZYGOTE,         /* A Linux zygote process. */
     SANDBOX_HELPER, /* A sandbox helper process. */
-    GPU,            /* A graphics process. */
-    ARC,            /* An ARC process. */
   };
 
   // Create a task with the given |title| and the given favicon |icon|. This
   // task runs on a process whose handle is |handle|. |rappor_sample| is the
   // name of the sample to be recorded if this task needs to be reported by
-  // Rappor.
+  // Rappor. If |process_id| is not supplied, it will be determined by |handle|.
   Task(const base::string16& title,
        const std::string& rappor_sample,
        const gfx::ImageSkia* icon,
-       base::ProcessHandle handle);
+       base::ProcessHandle handle,
+       base::ProcessId process_id = base::kNullProcessId);
   virtual ~Task();
 
   // Gets the name of the given |profile| from the ProfileAttributesStorage.
   static base::string16 GetProfileNameFromProfile(Profile* profile);
 
   // Activates this TaskManager's task by bringing its container to the front
   // (if possible).
   virtual void Activate();
 
   // Kills this task.
@@ skipping 27 matching lines @@
                                     int* out_error_code) const;
 
   // The name of the profile owning this task.
   virtual base::string16 GetProfileName() const;
 
   // Returns the unique ID of the tab if this task represents a renderer
   // WebContents used for a tab. Returns -1 if this task does not represent
   // a renderer, or a contents of a tab.
   virtual int GetTabId() const;
 
+  // For Tasks that represent a subactivity of some other task (e.g. a plugin
+  // embedded in a page), this returns the Task representing the parent
+  // activity.
+  virtual const Task* GetParentTask() const;
+
   // Getting the Sqlite used memory (in bytes). Not all tasks reports Sqlite
   // memory, in this case a default invalid value of -1 will be returned.
   // Check for whether the task reports it or not first.
   bool ReportsSqliteMemory() const;
   virtual int64_t GetSqliteMemoryUsed() const;
 
   // Getting the allocated and used V8 memory (in bytes). Not all tasks reports
   // V8 memory, in this case a default invalid value of -1 will be returned.
   // Check for whether the task reports it or not first.
   bool ReportsV8Memory() const;
@@ skipping 51 matching lines @@
 
   // The PID of the process on which this task is running.
   const base::ProcessId process_id_;
 
   DISALLOW_COPY_AND_ASSIGN(Task);
 };
 
 }  // namespace task_management
 
 #endif  // CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_TASK_H_