Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2028743002: Adding missing manifests to gn-built bro.exe (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 6 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing manifests to gn-built bro.exe Many executables are missing embedded manifest files when built with gn. This causes OS compatibility information to be omitted which can lead to strange behavior. This adds a manifest to bro.exe. BUG=602505 Committed: https://crrev.com/04b26cac6e20af2aff50b8a064691c605d79ae13 Cr-Commit-Position: refs/heads/master@{#397044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/brotli/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
Boilerplate change - PTAL.
4 years, 6 months ago (2016-05-31 18:24:21 UTC) #2
Kunihiko Sakamoto
lgtm
4 years, 6 months ago (2016-06-01 01:03:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028743002/1
4 years, 6 months ago (2016-06-01 01:06:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 03:47:56 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 03:49:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b26cac6e20af2aff50b8a064691c605d79ae13
Cr-Commit-Position: refs/heads/master@{#397044}

Powered by Google App Engine
This is Rietveld 408576698