Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2028713003: Fix AST-based type inference with explicit type parameters for method calls. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix AST-based type inference with explicit type parameters for method calls. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/73c7ca9a253656d1618e551b8a3e0ab99a7fc20d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -58 lines) Patch
M pkg/analyzer/lib/src/summary/format.fbs View 2 chunks +11 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +11 lines, -5 lines 2 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 7 chunks +85 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +10 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 7 chunks +44 lines, -30 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 15 chunks +83 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 6 months ago (2016-05-31 20:19:52 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2028713003/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/2028713003/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode1404 pkg/analyzer/lib/src/summary/idl.dart:1404: * the reference from [UnlinkedConst.references]. If `l` is ...
4 years, 6 months ago (2016-05-31 20:26:02 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 73c7ca9a253656d1618e551b8a3e0ab99a7fc20d (presubmit successful).
4 years, 6 months ago (2016-05-31 22:17:20 UTC) #5
Paul Berry
4 years, 6 months ago (2016-05-31 22:23:39 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2028713003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/2028713003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:1404: * the reference from
[UnlinkedConst.references].  If `l` is nonzero (where
On 2016/05/31 20:26:01, scheglov wrote:
> Consider using a different letter, maybe 'k', because 'l' looks too close to
'1'
> (one).

Done.

Powered by Google App Engine
This is Rietveld 408576698