⚽ Prefetch active tab state.

Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625
Committed: https://crrev.com/9685a9834992f2b8bb95bd0e3816034dce2fe2fd
Cr-Commit-Position: refs/heads/master@{#398551}

[Peter Wen, 2016-05-31 20:35:46]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2016-05-31 20:35:47]

⛲

[gone, 2016-05-31 22:48:31]

You should add a unit test for this to make sure it does what it needs to do.

https://chromiumcodereview.appspot.com/2028683003/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://chromiumcodereview.appspot.com/2028683003/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:649:
ContextUtils.getAppSharedPreferences().edit().putInt(PREF_ACTIVE_TAB_ID,
activeTabId);
How does this work without calling #apply()?

[Peter Wen, 2016-06-02 13:27:15]

Description was changed from

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574
==========

to

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574
==========

[Peter Wen, 2016-06-02 14:20:50]

https://codereview.chromium.org/2028683003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://codereview.chromium.org/2028683003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:649:
ContextUtils.getAppSharedPreferences().edit().putInt(PREF_ACTIVE_TAB_ID,
activeTabId);
On 2016/05/31 22:48:31, dfalcantara wrote:
> How does this work without calling #apply()?

Opps, fixed and added unit tests for this and previous CL. Thanks for the
reminder. :)

[Peter Wen, 2016-06-02 17:39:20]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 17:40:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028683003/60001

[commit-bot: I haz the power, 2016-06-02 19:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 19:00:19]

Dry run: This issue passed the CQ dry run.

[gone, 2016-06-02 21:03:14]

lgtm

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:75:
static final String PREF_HAS_RUN_FILE_MIGRATION =
nit: static final above private static final?

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
(right):

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java:269:
final TabPersistentStore store =
Do these variables have to be final?  It's not consistent with how the other
variables are set in the test.

[Peter Wen, 2016-06-06 13:49:23]

Thanks for the review! :)

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:75:
static final String PREF_HAS_RUN_FILE_MIGRATION =
On 2016/06/02 21:03:13, dfalcantara wrote:
> nit: static final above private static final?

Done.

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
(right):

https://codereview.chromium.org/2028683003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java:269:
final TabPersistentStore store =
On 2016/06/02 21:03:13, dfalcantara wrote:
> Do these variables have to be final?  It's not consistent with how the other
> variables are set in the test.

Done.

Opps, this was leftover from when I added the UI thread checks into the basic
test. Thanks for catching it. :)

[Peter Wen, 2016-06-06 13:50:07]

wnwen@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Peter Wen, 2016-06-06 13:50:07]

+asvitkine@ for adding one more histogram suffix OWNERS.

[Alexei Svitkine (slow), 2016-06-06 15:03:32]

lgtm

[Peter Wen, 2016-06-06 16:42:36]

On 2016/06/06 15:03:32, Alexei Svitkine (slow) wrote:
> lgtm

Thanks for the quick review!

@dfalcantara - will wait until another dev push as my previous optimization
didn't make it into dev yet. This way there's at least one dev release to
distinguish the effects of the two pre-warmups.

[Peter Wen, 2016-06-06 20:39:43]

Description was changed from

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574
==========

to

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625
==========

[Peter Wen, 2016-06-08 13:12:24]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-06-08 13:12:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2028683003/#ps80001
(title: "Remove unnecessary final.")

[commit-bot: I haz the power, 2016-06-08 13:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028683003/80001

[Peter Wen, 2016-06-08 13:13:25]

On 2016/06/06 16:42:36, Peter Wen wrote:
> On 2016/06/06 15:03:32, Alexei Svitkine (slow) wrote:
> > lgtm
> 
> Thanks for the quick review!
> 
> @dfalcantara - will wait until another dev push as my previous optimization
> didn't make it into dev yet. This way there's at least one dev release to
> distinguish the effects of the two pre-warmups.

Not waiting for dev anymore (another M52 push), both my changes are in M53. We
can kind of see the separate effect anyways just through the separate UMA stats.

[commit-bot: I haz the power, 2016-06-08 14:46:18]

Description was changed from

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625
==========

to

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625
==========

[commit-bot: I haz the power, 2016-06-08 14:46:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-08 14:48:46]

Description was changed from

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625
==========

to

==========
Prefetch active tab state.

- Store the active tab id as a shared preference every time the tab
  list is saved.

- Add a new AsyncTask to prefetch the previous active tab's TabState.
  The results of this task is used instead of synchronously restoring
  the active tab's TabState on startup.

- Currently, if the active tab model is incognito, then this will not
  speed up startup. The active incognito tab (if any) can be
  considered for prefetching later.

BUG=612574, 149625

Committed: https://crrev.com/9685a9834992f2b8bb95bd0e3816034dce2fe2fd
Cr-Commit-Position: refs/heads/master@{#398551}
==========

[commit-bot: I haz the power, 2016-06-08 14:48:47]

Patchset 5 (id:??) landed as
https://crrev.com/9685a9834992f2b8bb95bd0e3816034dce2fe2fd
Cr-Commit-Position: refs/heads/master@{#398551}