Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2028663002: S390: IC: Eliminate initialization_state as a factor in IC installation. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: IC: Eliminate initialization_state as a factor in IC installation. Port 56d90782a5a97e1854e9564056f45b6374664d75 Original commit message: In Crankshaft, we would install special ICs that didn't need a vector and slot in the MEGAMORPHIC case. This optimization limits our hand against future improvements. R=mvstanton@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/0ac67d74c658f3fae9f457a2ca68684a5bfc23a5 Cr-Commit-Position: refs/heads/master@{#36620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -51 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 5 chunks +13 lines, -26 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 5 chunks +7 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-05-31 15:03:34 UTC) #1
JaideepBajwa
lgtm
4 years, 6 months ago (2016-05-31 15:09:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028663002/1
4 years, 6 months ago (2016-05-31 16:35:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 17:01:07 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:02:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ac67d74c658f3fae9f457a2ca68684a5bfc23a5
Cr-Commit-Position: refs/heads/master@{#36620}

Powered by Google App Engine
This is Rietveld 408576698