Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: content/child/webcrypto/jwk.cc

Issue 202863004: Fix "unreachable code" warnings (MSVC warning 4702) in content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/npapi/webplugin_delegate_impl.cc ('k') | content/common/content_paths.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/jwk.cc
===================================================================
--- content/child/webcrypto/jwk.cc (revision 257821)
+++ content/child/webcrypto/jwk.cc (working copy)
@@ -702,7 +702,8 @@
extractable,
usage_mask,
key);
- } else if (jwk_kty_value == "RSA") {
+ }
+ if (jwk_kty_value == "RSA") {
// An RSA public key must have an "n" (modulus) and an "e" (exponent) entry
// in the JWK, while an RSA private key must have those, plus at least a "d"
// (private exponent) entry.
@@ -731,11 +732,9 @@
CryptoData(jwk_e_value),
key);
- } else {
- return Status::ErrorJwkUnrecognizedKty();
}
- return Status::Success();
+ return Status::ErrorJwkUnrecognizedKty();
}
Status ExportKeyJwk(const blink::WebCryptoKey& key,
« no previous file with comments | « content/child/npapi/webplugin_delegate_impl.cc ('k') | content/common/content_paths.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698