Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: content/child/indexed_db/indexed_db_key_builders.cc

Issue 202863004: Fix "unreachable code" warnings (MSVC warning 4702) in content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/child_thread.cc ('k') | content/child/npapi/webplugin_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/indexed_db/indexed_db_key_builders.cc
===================================================================
--- content/child/indexed_db/indexed_db_key_builders.cc (revision 257821)
+++ content/child/indexed_db/indexed_db_key_builders.cc (working copy)
@@ -62,8 +62,6 @@
NOTREACHED();
return IndexedDBKey();
}
- NOTREACHED();
- return IndexedDBKey();
}
WebIDBKey WebIDBKeyBuilder::Build(const IndexedDBKey& key) {
@@ -93,8 +91,6 @@
NOTREACHED();
return WebIDBKey::createInvalid();
}
- NOTREACHED();
- return WebIDBKey::createInvalid();
}
IndexedDBKeyRange IndexedDBKeyRangeBuilder::Build(
@@ -115,9 +111,10 @@
return IndexedDBKeyPath(CopyArray(key_path.array()));
case blink::WebIDBKeyPathTypeNull:
return IndexedDBKeyPath();
+ default:
+ NOTREACHED();
+ return IndexedDBKeyPath();
}
- NOTREACHED();
- return IndexedDBKeyPath();
}
blink::WebIDBKeyPath WebIDBKeyPathBuilder::Build(
@@ -129,9 +126,10 @@
return blink::WebIDBKeyPath::create(CopyArray(key_path.array()));
case blink::WebIDBKeyPathTypeNull:
return blink::WebIDBKeyPath::createNull();
+ default:
+ NOTREACHED();
+ return blink::WebIDBKeyPath::createNull();
}
- NOTREACHED();
- return blink::WebIDBKeyPath::createNull();
}
} // namespace content
« no previous file with comments | « content/child/child_thread.cc ('k') | content/child/npapi/webplugin_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698