Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/webrtc_audio_device_impl.cc

Issue 202863004: Fix "unreachable code" warnings (MSVC warning 4702) in content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/indexed_db/indexed_db_key.cc ('K') | « content/public/test/test_launcher.cc ('k') | content/shell/renderer/test_runner/TestPlugin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc_audio_device_impl.cc
===================================================================
--- content/renderer/media/webrtc_audio_device_impl.cc (revision 256983)
+++ content/renderer/media/webrtc_audio_device_impl.cc (working copy)
@@ -462,12 +462,7 @@
base::AutoLock auto_lock(lock_);
// Use the last |capturer| which is from the latest getUserMedia call as
// the default capture device.
- for (CapturerList::const_reverse_iterator iter = capturers_.rbegin();
- iter != capturers_.rend(); ++iter) {
- return *iter;
- }
-
- return NULL;
+ return capturers_.empty() ? NULL : capturers_.back();
Peter Kasting 2014/03/18 02:55:54 (Discussed this with xians to ensure this was real
}
void WebRtcAudioDeviceImpl::AddPlayoutSink(
« content/common/indexed_db/indexed_db_key.cc ('K') | « content/public/test/test_launcher.cc ('k') | content/shell/renderer/test_runner/TestPlugin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698